feat: customised setting details #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rando128
changed the title
|
Nice one @rando128 I merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR highlights in the coin settings view which setting differs from the global configuration.
This is done with a new function
warnIfAttributeCustomisedthat changes the CSS after comparing the symbol attribute value (this.props.symbolInfo.symbolConfiguration) with the global attribute value (this.props.configuration).This PR also adds the conservative mode setting in the settings view, since this has not been done in PR #585.
Motivation and Context
When playing with symbol settings, I often struggle to remember what I changed from the global settings and I end up going through a tedious comparison exercise. This feature helps identifying customised settings rapidly.
How Has This Been Tested?
This is working on my prod setup.
Screenshots (if appropriate):